Re: [PATCH 16/17] sym53c8xx: Remove pci_dev pointer from sym_shcb

2007-10-09 Thread Matthew Wilcox
On Fri, Oct 05, 2007 at 05:07:39PM -0400, Jeff Garzik wrote: > Obviously this is a judgement call on your part... but did you at least > consider passing sym_hcb for all cases instead? I did. There's a lot of crap stored in the sym_hcb that needs to move to the sym_data, so Scsi_host is going to

Re: [PATCH 16/17] sym53c8xx: Remove pci_dev pointer from sym_shcb

2007-10-05 Thread Jeff Garzik
Matthew Wilcox wrote: This structure is accessed by the device; the fewer Linux things in it, the better. Using the pci_dev pointer from the hostdata requires a lot of changes: - Pass Scsi_Host to a lot of routines which currently take a sym_hcb. - Set the Scsi_Host as the pci drvdata (instea

[PATCH 16/17] sym53c8xx: Remove pci_dev pointer from sym_shcb

2007-10-05 Thread Matthew Wilcox
This structure is accessed by the device; the fewer Linux things in it, the better. Using the pci_dev pointer from the hostdata requires a lot of changes: - Pass Scsi_Host to a lot of routines which currently take a sym_hcb. - Set the Scsi_Host as the pci drvdata (instead of the sym_hcb) Signe