Re: [PATCH 14/36] scsi_dh_alua: separate out alua_stpg()

2015-10-02 Thread Bart Van Assche
On 10/01/2015 11:06 PM, Hannes Reinecke wrote: On 10/02/2015 02:07 AM, Bart Van Assche wrote: The old implementation calls the callback function 'fn' if the flag TPGS_MODE_EXPLICIT has not been set but the new implementation not. Please mention this in the patch description if this behavior chan

Re: [PATCH 14/36] scsi_dh_alua: separate out alua_stpg()

2015-10-01 Thread Hannes Reinecke
On 10/02/2015 02:07 AM, Bart Van Assche wrote: > On 09/29/2015 03:47 AM, Hannes Reinecke wrote: >> Seperate out SET TARGET PORT GROUP functionality into a separate > ^ Separate ? >> function alua_stpg(). >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/scsi/device_handler/scsi_dh_alua.c

Re: [PATCH 14/36] scsi_dh_alua: separate out alua_stpg()

2015-10-01 Thread Bart Van Assche
On 09/29/2015 03:47 AM, Hannes Reinecke wrote: Seperate out SET TARGET PORT GROUP functionality into a separate ^ Separate ? function alua_stpg(). Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 86 ++ 1 file changed, 52 inserti

[PATCH 14/36] scsi_dh_alua: separate out alua_stpg()

2015-09-29 Thread Hannes Reinecke
Seperate out SET TARGET PORT GROUP functionality into a separate function alua_stpg(). Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 86 ++ 1 file changed, 52 insertions(+), 34 deletions(-) diff --git a/drivers/scsi/device_handler/sc