Matthew Wilcox wrote:
On Tue, Oct 09, 2007 at 11:35:14AM -0400, Jeff Garzik wrote:
Not true. The original code used 'int irq', and the printf format was
correct as a result.
You changed the code to use 'unsigned int irq' as found in struct
pci_dev, without changing IRQ_FMT as needed.
If yo
On Tue, Oct 09, 2007 at 11:35:14AM -0400, Jeff Garzik wrote:
> Not true. The original code used 'int irq', and the printf format was
> correct as a result.
>
> You changed the code to use 'unsigned int irq' as found in struct
> pci_dev, without changing IRQ_FMT as needed.
>
> If you wanted to
Matthew Wilcox wrote:
On Fri, Oct 05, 2007 at 04:59:47PM -0400, Jeff Garzik wrote:
NAK
The proper format string is '%u' because irq is unsigned
I'll change it to %u in the next revision. However, I respectfully
decline your NAK as this was not a regression.
Not true. The original code use
On Fri, Oct 05, 2007 at 04:59:47PM -0400, Jeff Garzik wrote:
> NAK
>
> The proper format string is '%u' because irq is unsigned
I'll change it to %u in the next revision. However, I respectfully
decline your NAK as this was not a regression.
--
Intel are signing my paycheques ... these opinion
Matthew Wilcox wrote:
@@ -1196,8 +1193,8 @@ static int sym_host_info(struct sym_hcb *np, char *ptr,
off_t offset, int len)
copy_info(&info, "Chip " NAME53C "%s, device id 0x%x, "
"revision id 0x%x\n", np->s.chip_name,
np->s.device->device
These macros aren't needed any more. They used to be used for SPARC.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/sym53c8xx_2/sym_glue.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c
b/drivers/scsi/sy
6 matches
Mail list logo
