Re: [PATCH 12/23] scsi_dh_alua: switch to scsi_execute_req_flags()

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > All commands are issued synchronously, so no need to open-code > scsi_execute_req_flags() anymore. And we can get rid of the > static sense code structure element. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/s

Re: [PATCH 12/23] scsi_dh_alua: switch to scsi_execute_req_flags()

Looks good fine, but please add a comment explaining why the REQ_QUIET and REQ_PREEMPT flags added by scsi_execture are fine, or in fact desireable. Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.k

[PATCH 12/23] scsi_dh_alua: switch to scsi_execute_req_flags()

All commands are issued synchronously, so no need to open-code scsi_execute_req_flags() anymore. And we can get rid of the static sense code structure element. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 124 - 1 file changed, 34 in