Re: [PATCH 12/20] scsi: merge print_opcode_name()

2014-09-05 Thread Christoph Hellwig
On Fri, Sep 05, 2014 at 10:24:40AM +0900, Yoshihiro YUNOMAE wrote: > > #define SA_NAME_LIST_SZ ARRAY_SIZE(sa_names_arr) > > We can delete SA_NAME_LIST_SZ because we define it out of > CONFIG_SCSI_CONSTANTS. I'd generally prefer to just use ARRAY_SIZE() directly instead of adding another layer o

Re: [PATCH 12/20] scsi: merge print_opcode_name()

2014-09-04 Thread Yoshihiro YUNOMAE
(2014/09/03 19:06), Hannes Reinecke wrote: > Instead of having two versions of print_opcode_name() we > should be consolidating them into one version. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/constants.c | 90 > +++- > 1 file changed,

[PATCH 12/20] scsi: merge print_opcode_name()

2014-09-03 Thread Hannes Reinecke
Instead of having two versions of print_opcode_name() we should be consolidating them into one version. Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 90 +++- 1 file changed, 35 insertions(+), 55 deletions(-) diff --git a/drivers/scsi/