Re: [PATCH 12/17] scsi: avoid taking host_lock in scsi_run_queue unless nessecary

2014-02-06 Thread Christoph Hellwig
On Wed, Feb 05, 2014 at 03:54:17PM -0800, James Bottomley wrote: > > -/* > > - * Function: scsi_run_queue() > > - * > > - * Purpose:Select a proper request queue to serve next > > - * > > - * Arguments: q - last request's queue > > - * > > - * Returns: Nothing > > - * >

Re: [PATCH 12/17] scsi: avoid taking host_lock in scsi_run_queue unless nessecary

2014-02-05 Thread James Bottomley
On Wed, 2014-02-05 at 04:39 -0800, Christoph Hellwig wrote: > If we don't have starved devices we don't need to take the host lock > to iterate over them. Also split the function up to be more clear. This looks reasonable and can potentially go separately too. > Signed-off-by: Christoph Hellwig

[PATCH 12/17] scsi: avoid taking host_lock in scsi_run_queue unless nessecary

2014-02-05 Thread Christoph Hellwig
If we don't have starved devices we don't need to take the host lock to iterate over them. Also split the function up to be more clear. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_lib.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --