RE: [PATCH 10/16] aacraid: Terminate kthread on controller fw assert

2017-02-16 Thread Raghava Aditya Renukunta
aran > ; Scott Benesh > ; dan.carpen...@oracle.com > Subject: Re: [PATCH 10/16] aacraid: Terminate kthread on controller fw > assert > > EXTERNAL EMAIL > > > On 02/15/2017 11:22 PM, Raghava Aditya Renukunta wrote: > >> > >> This look a bit scary. C

Re: [PATCH 10/16] aacraid: Terminate kthread on controller fw assert

2017-02-16 Thread Johannes Thumshirn
On 02/15/2017 11:22 PM, Raghava Aditya Renukunta wrote: >> >> This look a bit scary. Can't the kthread be converted to a workqueue so >> we could call cancel_work_sync()? > > Could you please elaborate on the reasons why this fix is scary? > I understand that killing a thread is not standard (for

RE: [PATCH 10/16] aacraid: Terminate kthread on controller fw assert

2017-02-15 Thread Raghava Aditya Renukunta
na Sridaran > ; Scott Benesh > ; dan.carpen...@oracle.com > Subject: Re: [PATCH 10/16] aacraid: Terminate kthread on controller fw > assert > > EXTERNAL EMAIL > > > On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote: > > When the command thread performs a periodi

Re: [PATCH 10/16] aacraid: Terminate kthread on controller fw assert

2017-02-15 Thread Johannes Thumshirn
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote: > When the command thread performs a periodic time sync and the firmware is > going through an assert during that time, the command thread waits for the > response that would never arrive. The SCSI Mid layer's error handler would > eventually

[PATCH 10/16] aacraid: Terminate kthread on controller fw assert

2017-02-14 Thread Raghava Aditya Renukunta
When the command thread performs a periodic time sync and the firmware is going through an assert during that time, the command thread waits for the response that would never arrive. The SCSI Mid layer's error handler would eventually reset the controller, but the eh_handler just issues a "thread s