Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-04 Thread Andreas Herrmann
On Sat, Sep 03, 2005 at 14:53:00, Christoph Hellwig wrote: > Please don't do this. We have proper midlayer handling (plus FC > transport > class wrappers) to handle that case without introducing a big mess in > the > driver. Please take a look at fc_remote_port_{block,unblock} Thanks for t

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-04 Thread Andreas Herrmann
James, I wished I would have put patch 1/7 at the end of the patch series ;-( Because if patch 1 is not applied the other patches won't apply without rejects. I am on vacation for 1 week and I am not able to recreate the patches before 12th of September. Do you see any problems to bring the new

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-04 Thread Andreas Herrmann
On Sat, 2005-09-03 13:45:01, James Bottomley wrote: > But that's not what the patch does. It short circuits the error > handler > globally, not just in the cable pulled case. > For any error induced timeout, you're going to follow this logic. In > particular, if the device itself actua

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread Christoph Hellwig
On Sat, Sep 03, 2005 at 02:30:42PM +0200, Andreas Herrmann wrote: > zfcp: introduce eh_timed_out handler > > This handler is required to avoid offlined SCSI devices in a multipath > setup if scsi commands time out on cable pulls lasting longer than 30 > seconds. Please don't do this. We have pro

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread James Bottomley
On Sat, 2005-09-03 at 14:30 +0200, Andreas Herrmann wrote: > zfcp: introduce eh_timed_out handler > > This handler is required to avoid offlined SCSI devices in a multipath > setup if scsi commands time out on cable pulls lasting longer than 30 > seconds. But that's not what the patch does. It s

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread Andreas Herrmann
On 03.09.2005 14:56 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > zfcp: introduce eh_timed_out handler > > > > This handler is required to avoid offlined SCSI devices in a multipath > > setup if scsi commands time out on cable pulls lasting longer than 30 > > seconds. > hmm why i

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread Arjan van de Ven
On Sat, 2005-09-03 at 14:30 +0200, Andreas Herrmann wrote: > zfcp: introduce eh_timed_out handler > > This handler is required to avoid offlined SCSI devices in a multipath > setup if scsi commands time out on cable pulls lasting longer than 30 > seconds. hmm why is this needed? doesn't the fc t

[PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread Andreas Herrmann
zfcp: introduce eh_timed_out handler This handler is required to avoid offlined SCSI devices in a multipath setup if scsi commands time out on cable pulls lasting longer than 30 seconds. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diff -Nup linux-2.6.13/drivers/s390/scsi-orig/zfcp_scsi.c