Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-07-07 Thread Sebastian Andrzej Siewior
On 2017-07-07 09:20:02 [-0400], Chad Dupuis wrote: > What was the question? My observation is that the patch I proposed fixed > the issue we saw on testing the patch set. With that small change > (essentially modulo by the number of active CPUs vs. the total number) > your patch set worked ok.

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-07-07 Thread Chad Dupuis
On Fri, 7 Jul 2017, 9:14am, Sebastian Andrzej Siewior wrote: > On 2017-06-29 15:57:56 [+0200], Johannes Thumshirn wrote: > > So here we are again, > > Tested-by: Johannes Thumshirn > > > > FCoE will follow as soon as my setup can speak FCoE again. > > So it all looks good, doesn't it? Chad ne

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-07-07 Thread Sebastian Andrzej Siewior
On 2017-06-29 15:57:56 [+0200], Johannes Thumshirn wrote: > So here we are again, > Tested-by: Johannes Thumshirn > > FCoE will follow as soon as my setup can speak FCoE again. So it all looks good, doesn't it? Chad never responded to my question on his patch. I still doubt that it fixes the pro

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-06-29 Thread Johannes Thumshirn
So here we are again, Tested-by: Johannes Thumshirn FCoE will follow as soon as my setup can speak FCoE again. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-05-09 Thread Rangankar, Manish
On 10/04/17 10:42 PM, "Sebastian Andrzej Siewior" wrote: >The driver creates its own per-CPU threads which are updated based on CPU >hotplug events. It is also possible to use kworkers and remove some of the >infrastructure get the same job done while saving a few lines of code. > >The DECLARE_P

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-05-05 Thread Johannes Thumshirn
On 04/10/2017 07:12 PM, Sebastian Andrzej Siewior wrote: > The driver creates its own per-CPU threads which are updated based on CPU > hotplug events. It is also possible to use kworkers and remove some of the > infrastructure get the same job done while saving a few lines of code. > > The DECLARE

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-05-05 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

[PATCH 1/5] scsi: bnx2i: convert to workqueue

2017-04-10 Thread Sebastian Andrzej Siewior
The driver creates its own per-CPU threads which are updated based on CPU hotplug events. It is also possible to use kworkers and remove some of the infrastructure get the same job done while saving a few lines of code. The DECLARE_PER_CPU() definition is moved into the header file where it belong

[PATCH 1/5] scsi: bnx2i: convert to workqueue

2016-11-22 Thread Sebastian Andrzej Siewior
The driver creates its own per-CPU threads which are updated based on CPU hotplug events. It is also possible to use kworkers and remove some of the infrastructure get the same job done while saving a few lines of code. The DECLARE_PER_CPU() definition is moved into the header file where it belong