Re: [PATCH 1/5] qedf: fixup bit operations

2018-09-06 Thread Martin Wilck
On Thu, 2018-09-06 at 09:03 +0200, Hannes Reinecke wrote: > On 09/05/2018 04:09 PM, Martin Wilck wrote: > > On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote: > > > test_bit() is atomic, test_bit() || test_bit() is not. > > > So protect consecutive bit tests with a lock to avoid races. > > >

Re: [PATCH 1/5] qedf: fixup bit operations

2018-09-06 Thread Hannes Reinecke
On 09/05/2018 04:09 PM, Martin Wilck wrote: > On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote: >> test_bit() is atomic, test_bit() || test_bit() is not. >> So protect consecutive bit tests with a lock to avoid races. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/scsi/qedf/qedf_e

Re: [PATCH 1/5] qedf: fixup bit operations

2018-09-05 Thread Martin Wilck
On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote: > test_bit() is atomic, test_bit() || test_bit() is not. > So protect consecutive bit tests with a lock to avoid races. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/qedf/qedf_els.c | 9 +++-- > drivers/scsi/qedf/qedf_main.

[PATCH 1/5] qedf: fixup bit operations

2018-09-05 Thread Hannes Reinecke
test_bit() is atomic, test_bit() || test_bit() is not. So protect consecutive bit tests with a lock to avoid races. Signed-off-by: Hannes Reinecke --- drivers/scsi/qedf/qedf_els.c | 9 +++-- drivers/scsi/qedf/qedf_main.c | 5 - 2 files changed, 11 insertions(+), 3 deletions(-) diff --g