Re: [PATCH 1/4] sg: disable SET_FORCE_LOW_DMA

2017-02-03 Thread Christoph Hellwig
On Fri, Feb 03, 2017 at 10:32:28AM +0100, Johannes Thumshirn wrote: > I'm not sure if returning a bogus '0' is better here to not break any > existing application, which assumed it always worked. Agreed, this should return 0, and maybe also print a (ratelimited) warning.

Re: [PATCH 1/4] sg: disable SET_FORCE_LOW_DMA

2017-02-03 Thread Hannes Reinecke
On 02/03/2017 10:32 AM, Johannes Thumshirn wrote: > > On 02/03/2017 09:54 AM, Hannes Reinecke wrote: >> The ioctl SET_FORCE_LOW_DMA has never worked since the initial >> git check-in, and the respective setting is nowadays handled >> correctly. >> So disable it entirely. >> >> Signed-off-by: Hanne

Re: [PATCH 1/4] sg: disable SET_FORCE_LOW_DMA

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 09:54 AM, Hannes Reinecke wrote: The ioctl SET_FORCE_LOW_DMA has never worked since the initial git check-in, and the respective setting is nowadays handled correctly. So disable it entirely. Signed-off-by: Hannes Reinecke --- [...] case SG_SET_FORCE_LOW_DMA: -

[PATCH 1/4] sg: disable SET_FORCE_LOW_DMA

2017-02-03 Thread Hannes Reinecke
The ioctl SET_FORCE_LOW_DMA has never worked since the initial git check-in, and the respective setting is nowadays handled correctly. So disable it entirely. Signed-off-by: Hannes Reinecke --- drivers/scsi/sg.c | 27 +-- include/scsi/sg.h | 1 - 2 files changed, 5 inser