Re: [PATCH 1/4] libata: consolidate ata_dev_classify()

2014-09-07 Thread Tejun Heo
On Sun, Sep 07, 2014 at 01:24:47PM +0200, Hannes Reinecke wrote: > Which was actually my first attempt, but then I figured I'd be > increasing the stacksize in doing so. > But sure, if you're okay with it I'll be redoing the patch. The struct is only 32 bytes. I don't think it's gonna make any me

Re: [PATCH 1/4] libata: consolidate ata_dev_classify()

2014-09-07 Thread Hannes Reinecke
On 09/06/2014 02:52 PM, Tejun Heo wrote: Hello, On Sat, Sep 06, 2014 at 10:21:51AM +0200, Hannes Reinecke wrote: Well, yes, in principle. I was looking into that, too. But then I figured that moving to ata_taskfile would be a major overhaul for libsas, which would be quite beyond scope here. An

Re: [PATCH 1/4] libata: consolidate ata_dev_classify()

2014-09-06 Thread Tejun Heo
Hello, On Sat, Sep 06, 2014 at 10:21:51AM +0200, Hannes Reinecke wrote: > Well, yes, in principle. I was looking into that, too. > But then I figured that moving to ata_taskfile would be a major overhaul for > libsas, which would be quite beyond scope here. > And all for a puny little patch. Hmm?

Re: [PATCH 1/4] libata: consolidate ata_dev_classify()

2014-09-06 Thread Hannes Reinecke
On 09/06/2014 01:42 AM, Tejun Heo wrote: Hello, Hannes. Sorry about the delay. On Wed, Jul 30, 2014 at 09:55:08AM +0200, Hannes Reinecke wrote: ata_dev_classify() just uses the 'lbah' and 'lbam' fields from the taskfile, so we can as well use those as arguments and rip out the custom code from

Re: [PATCH 1/4] libata: consolidate ata_dev_classify()

2014-09-05 Thread Tejun Heo
Hello, Hannes. Sorry about the delay. On Wed, Jul 30, 2014 at 09:55:08AM +0200, Hannes Reinecke wrote: > ata_dev_classify() just uses the 'lbah' and 'lbam' > fields from the taskfile, so we can as well use those > as arguments and rip out the custom code from sas_ata. I wonder whether it'd easie

[PATCH 1/4] libata: consolidate ata_dev_classify()

2014-07-30 Thread Hannes Reinecke
ata_dev_classify() just uses the 'lbah' and 'lbam' fields from the taskfile, so we can as well use those as arguments and rip out the custom code from sas_ata. Cc: Dan Williams Signed-off-by: Hannes Reinecke --- drivers/ata/libahci.c | 11 +++ drivers/ata/libata-core.c

[PATCH 1/4] libata: consolidate ata_dev_classify()

2014-07-29 Thread Hannes Reinecke
ata_dev_classify() just uses the 'lbah' and 'lbam' fields from the taskfile, so we can as well use those as arguments and rip out the custom code from sas_ata. Cc: Tejun Heo Cc: Dan Williams Signed-off-by: Hannes Reinecke --- drivers/ata/libahci.c | 11 +++ drivers/ata/libata

[PATCH 1/4] libata: consolidate ata_dev_classify()

2014-07-21 Thread Hannes Reinecke
ata_dev_classify() just uses the 'lbah' and 'lbam' fields from the taskfile, so we can as well use those as arguments and rip out the custom code from sas_ata. Cc: Tejun Heo Cc: Dan Williams Signed-off-by: Hannes Reinecke --- drivers/ata/libahci.c | 11 +++ drivers/ata/libata