Re: [PATCH 1/3] libata-scsi: Set CmdQue=1 when NCQ is enabled

2016-05-03 Thread Tom Yan
Btw I wonder if the CmdQue bit should be statically set to 1 instead. It is not specified in the SAT standard (as of SAT-4 Rev. 05a) that the bit should be correlated to ATA NCQ. Neither does the kernel care about the bit (or the 'queue_type' sysfs file), apparently. However, it seems that there is

[PATCH 1/3] libata-scsi: Set CmdQue=1 when NCQ is enabled

2016-05-02 Thread tom . ty89
From: Tom Yan https://bugzilla.kernel.org/show_bug.cgi?id=105931 This might look trivial at first sight. However, it can be important to have the bit set accordingly when the device/SATL is SCSI-passthrough'd to a virtual machine with scsi-block in qemu: https://github.com/YanVugenfirer/kvm-gue