Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

On 05/14/2014 05:57 PM, Nicholas A. Bellinger wrote: On Wed, 2014-05-14 at 17:22 -0700, Andy Grover wrote: On 05/14/2014 05:07 PM, Nicholas A. Bellinger wrote: On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: Just like for pSCSI, if the transport sets get_write_cache, then it is not valid

Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

On Wed, 2014-05-14 at 17:22 -0700, Andy Grover wrote: > On 05/14/2014 05:07 PM, Nicholas A. Bellinger wrote: > > On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: > >> Just like for pSCSI, if the transport sets get_write_cache, then it is > >> not valid to enable write cache emulation for it. R

Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

On 05/14/2014 05:07 PM, Nicholas A. Bellinger wrote: On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: Just like for pSCSI, if the transport sets get_write_cache, then it is not valid to enable write cache emulation for it. Return an error. see https://bugzilla.redhat.com/show_bug.cgi?id=10

Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: > Just like for pSCSI, if the transport sets get_write_cache, then it is > not valid to enable write cache emulation for it. Return an error. > > see https://bugzilla.redhat.com/show_bug.cgi?id=1082675 > > Reviewed-by: Chris Leech > Signed-of

[PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

Just like for pSCSI, if the transport sets get_write_cache, then it is not valid to enable write cache emulation for it. Return an error. see https://bugzilla.redhat.com/show_bug.cgi?id=1082675 Reviewed-by: Chris Leech Signed-off-by: Andy Grover --- drivers/target/target_core_device.c | 8