Re: [PATCH 1/2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

2019-03-29 Thread Bart Van Assche
On Wed, 2019-03-27 at 17:26 +0800, Ming Lei wrote: > Some of SCSI commands are allowed when the state is SDEV_QUIESCE, > what if these commands need EH to make progress? Since scsi_target_block() changes the device state into SDEV_BLOCK I think this patch should check for the SDEV_BLOCK state inst

Re: [PATCH 1/2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

2019-03-29 Thread Martin K. Petersen
> Some of SCSI commands are allowed when the state is SDEV_QUIESCE, > what if these commands need EH to make progress? Bart: Please clarify! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

2019-03-27 Thread Ming Lei
On Wed, Mar 27, 2019 at 4:44 AM Bart Van Assche wrote: > > Several SCSI transport and LLD drivers surround code that does not > tolerate concurrent calls of .queuecommand() with scsi_target_block() / > scsi_target_unblock(). These last two functions use > blk_mq_quiesce_queue() / blk_mq_unquiesce_

Re: [PATCH 1/2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

2019-03-27 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH 1/2] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

2019-03-26 Thread Bart Van Assche
Several SCSI transport and LLD drivers surround code that does not tolerate concurrent calls of .queuecommand() with scsi_target_block() / scsi_target_unblock(). These last two functions use blk_mq_quiesce_queue() / blk_mq_unquiesce_queue() for scsi-mq request queues to prevent concurrent .queuecom