Re: [PATCH 1/2] fix EH thread teardown

2005-09-08 Thread Rolf Eike Beer
Christoph Hellwig wrote: >As Rolf Eike Beer noted we might not actually get to the >kthread_should_stop() because we are waiting in the semaphore forever. >I didn't get a rmmod hang because of this, but my instrumentation showed >the thread defitiyly didn't exit. > >So make sure to wake the EH thre

Re: [PATCH 1/2] fix EH thread teardown

2005-09-07 Thread Rolf Eike Beer
Christoph Hellwig wrote: >As Rolf Eike Beer noted we might not actually get to the >kthread_should_stop() because we are waiting in the semaphore forever. >I didn't get a rmmod hang because of this, but my instrumentation showed >the thread defitiyly didn't exit. > >So make sure to wake the EH thre

[PATCH 1/2] fix EH thread teardown

2005-09-07 Thread Christoph Hellwig
As Rolf Eike Beer noted we might not actually get to the kthread_should_stop() because we are waiting in the semaphore forever. I didn't get a rmmod hang because of this, but my instrumentation showed the thread defitiyly didn't exit. So make sure to wake the EH thread before the kthread_stop, and