Re: [PATCH 1/2] brd: Fix the partitions BUG

2014-07-30 Thread Boaz Harrosh
On 07/30/2014 07:50 PM, Ross Zwisler wrote: <> >> + */ >> +printk(KERN_EROR "brd: brd_find unexpected device %d\n", i); > > s/KERN_EROR/KERN_ERR/ > Yes thanks, sigh, code should compile driver error. I used pr_err but last inspection I saw that printk is used everywhere and, crapped ...

Re: [PATCH 1/2] brd: Fix the partitions BUG

2014-07-30 Thread Ross Zwisler
On Wed, 2014-07-30 at 17:15 +0300, Boaz Harrosh wrote: > With current code after a call to: > bdev = blkdev_get_by_path(dev_name, mode, fs_type); > size = i_size_read(bdev->bd_inode); > part_size = bdev->bd_part->nr_sects << 9; > > I get the following bad results: > dev_name ==

[PATCH 1/2] brd: Fix the partitions BUG

2014-07-30 Thread Boaz Harrosh
With current code after a call to: bdev = blkdev_get_by_path(dev_name, mode, fs_type); size = i_size_read(bdev->bd_inode); part_size = bdev->bd_part->nr_sects << 9; I get the following bad results: dev_name == /dev/ram0 foo: [foo_mount:880] size=0x4000 bdev=8800