Re: [PATCH 1/1] target:separate tx/rx cmd_puds

2019-04-15 Thread David Disseldorp
[replying to an old thread] On Sun, 8 Apr 2018 11:57:18 +0800, Zhang Zhuoyu wrote: > > On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote: > > > > > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds); > > > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds); > > > > +CONFIGFS_ATTR_RO(

RE: [PATCH 1/1] target:separate tx/rx cmd_puds

2018-04-07 Thread Zhang Zhuoyu
> -Original Message- > From: David Disseldorp [mailto:dd...@suse.de] > Sent: Friday, April 6, 2018 8:10 PM > To: Zhang Zhuoyu > Cc: n...@linux-iscsi.org; linux-scsi@vger.kernel.org; target- > de...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH

Re: [PATCH 1/1] target:separate tx/rx cmd_puds

2018-04-06 Thread David Disseldorp
On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote: > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds); > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds); > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds); > > I don't think the in_cmds metric should be deleted here. It could b

Re: [PATCH 1/1] target:separate tx/rx cmd_puds

2018-04-05 Thread David Disseldorp
Hi, The commit summary has a typo (cmd_puds). That said, this change isn't iSCSI specific, so using "pdu" here doesn't make much sense IMO. On Wed, 21 Mar 2018 17:52:43 +0800, Zhang Zhuoyu wrote: > Separate tx/rx cmd_pdus in order to distinguish LUN read/write IOPS. > > Signed-off-by: Zhang Zhu

[PATCH 1/1] target:separate tx/rx cmd_puds

2018-03-21 Thread Zhang Zhuoyu
Separate tx/rx cmd_pdus in order to distinguish LUN read/write IOPS. Signed-off-by: Zhang Zhuoyu --- drivers/target/target_core_stat.c | 26 ++ drivers/target/target_core_transport.c | 11 ++- include/target/target_core_base.h | 3 ++- 3 files changed,