Re: [PATCH 1/1] qla2xxx: Initialize Work element before requesting IRQs

2017-10-25 Thread Madhani, Himanshu
Hello Bart, > On Oct 17, 2017, at 9:12 PM, Bart Van Assche wrote: > > On Mon, 2017-10-16 at 11:26 -0700, Madhani, Himanshu wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c >> index 937209805baf..3bd956d3bc5d 100644 >> --- a/drivers/scsi/qla2xxx/qla_os.c >> ++

Re: [PATCH 1/1] qla2xxx: Initialize Work element before requesting IRQs

2017-10-17 Thread Bart Van Assche
On Mon, 2017-10-16 at 11:26 -0700, Madhani, Himanshu wrote: > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > index 937209805baf..3bd956d3bc5d 100644 > --- a/drivers/scsi/qla2xxx/qla_os.c > +++ b/drivers/scsi/qla2xxx/qla_os.c > @@ -3061,6 +3061,8 @@ qla2x00_probe_one(st

Re: [PATCH 1/1] qla2xxx: Initialize Work element before requesting IRQs

2017-10-16 Thread Martin K. Petersen
Himanshu, > commit a9e170e28636 ("scsi: qla2xxx: Fix uninitialized work element") > moved initialziation of work element earlier in the probe to fix call > stack. However, it still leaves a window where interrupt can be > generated before work element is initialized. Fix that window by > Initiali

[PATCH 1/1] qla2xxx: Initialize Work element before requesting IRQs

2017-10-16 Thread Madhani, Himanshu
From: Himanshu Madhani commit a9e170e28636 ("scsi: qla2xxx: Fix uninitialized work element") moved initialziation of work element earlier in the probe to fix call stack. However, it still leaves a window where interrupt can be generated before work element is initialized. Fix that window by Initi