Re: [PATCH 1/1] cxlflash: Base support for IBM CXL Flash Adapter

2015-05-21 Thread Michael Neuling
> >> +#define CXLFLASH_MAX_CMDS 16 > >> +#define CXLFLASH_MAX_CMDS_PER_LUN CXLFLASH_MAX_CMDS > >> + > >> +#define NOT_POW2(_x) ((_x) & ((_x) & ((_x) - 1))) > > > > include/linux/log2 has is_power_of_2() > > > > This is used for compile-time enforcement. The items in the log2

Re: [PATCH 1/1] cxlflash: Base support for IBM CXL Flash Adapter

2015-05-21 Thread Matthew R. Ochs
Mikey, Thanks for reviewing this patch. Responses are inline below. -matt On May 20, 2015, at 12:51 AM, Michael Neuling wrote: > Does this driver work when compiled big endian? We haven't tested on big endian but agree that the code should support both little and big endian. >> >> +#define