Re: [PATCH 1/1] [PATCH REGRESSION] alua: fix bus detach oops

2015-01-29 Thread Mike Christie
On 01/29/2015 02:45 AM, Hannes Reinecke wrote: > On 01/28/2015 10:46 AM, micha...@cs.wisc.edu wrote: >> From: Mike Christie >> >> This fixes a regression caused by commit >> 1d5203284d8acbdfdf9b478d434450b34f338f28 >> >> The bug is that the alua detach() callout will try to access the >> sddev->sc

Re: [PATCH 1/1] [PATCH REGRESSION] alua: fix bus detach oops

2015-01-29 Thread Christoph Hellwig
On Thu, Jan 29, 2015 at 09:45:24AM +0100, Hannes Reinecke wrote: > Errm. > > We save the contents first: > > > struct scsi_device_handler *scsi_dh = scsi_dh_data->scsi_dh; > > Then set the pointer to NULL: > > > sdev->scsi_dh_data = NULL; > > and then call 'detach': > > > scsi_dh-

Re: [PATCH 1/1] [PATCH REGRESSION] alua: fix bus detach oops

2015-01-29 Thread Hannes Reinecke
On 01/28/2015 10:46 AM, micha...@cs.wisc.edu wrote: > From: Mike Christie > > This fixes a regression caused by commit > 1d5203284d8acbdfdf9b478d434450b34f338f28 > > The bug is that the alua detach() callout will try to access the > sddev->scsi_dh_data, but we have already set it to NULL. This p

[PATCH 1/1] [PATCH REGRESSION] alua: fix bus detach oops

2015-01-28 Thread michaelc
From: Mike Christie This fixes a regression caused by commit 1d5203284d8acbdfdf9b478d434450b34f338f28 The bug is that the alua detach() callout will try to access the sddev->scsi_dh_data, but we have already set it to NULL. This patch moves the clearing of that field to after detach() is called.