Re: [PATCH 08/20] scsi_dh_alua: use unique device id

2015-12-31 Thread Hannes Reinecke
On 12/30/2015 12:20 PM, Christoph Hellwig wrote: On Tue, Dec 08, 2015 at 08:37:28AM +0100, Hannes Reinecke wrote: Use scsi_vpd_lun_id() to assign a unique device identification to the alua port group structure. I really hate the fix length arrays and how they are passed around. You and me bo

Re: [PATCH 08/20] scsi_dh_alua: use unique device id

2015-12-30 Thread Christoph Hellwig
On Tue, Dec 08, 2015 at 08:37:28AM +0100, Hannes Reinecke wrote: > Use scsi_vpd_lun_id() to assign a unique device identification > to the alua port group structure. I really hate the fix length arrays and how they are passed around. Can't you move the call to scsi_vpd_lun_id into alua_get_pg (al

[PATCH 08/20] scsi_dh_alua: use unique device id

2015-12-07 Thread Hannes Reinecke
Use scsi_vpd_lun_id() to assign a unique device identification to the alua port group structure. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 64 -- 1 file changed, 61 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/device_h