Re: [PATCH 08/18] block: Make scsi_req_init() calls implicit

2017-05-20 Thread Christoph Hellwig
On Fri, May 19, 2017 at 11:30:06AM -0700, Bart Van Assche wrote: > Instead of explicitly calling scsi_req_init(), let > blk_get_request() call that function from inside blk_rq_init(). > Add an .initialize_rq_fn() callback function to the block drivers > that need it. Thanks Bart, this looks like

[PATCH 08/18] block: Make scsi_req_init() calls implicit

2017-05-19 Thread Bart Van Assche
Instead of explicitly calling scsi_req_init(), let blk_get_request() call that function from inside blk_rq_init(). Add an .initialize_rq_fn() callback function to the block drivers that need it. Merge the IDE .init_rq_fn() function into .initialize_rq_fn() because it is too small to keep it as a se