Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2008-02-01 Thread Russell King
On Sun, Dec 16, 2007 at 05:28:33PM +0200, Boaz Harrosh wrote: > Russell or any other arm person. Please first see if this compiles at all, as > I do > not have a cross compiler set up, and please check that this code works. > (Should apply on top of Linus latest) This patch seems to work with one

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2008-01-31 Thread James Bottomley
On Wed, 2007-09-12 at 08:42 +0100, Russell King wrote: > On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote: > > - if (SCpnt->request_bufflen != len) > > + if (scsi_bufflen(SCpnt) != len) { > > + WARN_ON(1); > > NAK. The call trace generally doesn'

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2007-12-16 Thread Boaz Harrosh
On Sat, Dec 15 2007 at 2:27 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-09-18 at 17:04 +0200, Boaz Harrosh wrote: >> On Wed, Sep 12 2007 at 10:42 +0300, Russell King <[EMAIL PROTECTED]> wrote: >>> On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote: - if

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2007-12-15 Thread James Bottomley
On Tue, 2007-09-18 at 17:04 +0200, Boaz Harrosh wrote: > On Wed, Sep 12 2007 at 10:42 +0300, Russell King <[EMAIL PROTECTED]> wrote: > > On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote: > >> - if (SCpnt->request_bufflen != len) > >> + if (scsi_bufflen(SCpnt) != len)

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2007-09-18 Thread Boaz Harrosh
On Wed, Sep 12 2007 at 10:42 +0300, Russell King <[EMAIL PROTECTED]> wrote: > On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote: >> -if (SCpnt->request_bufflen != len) >> +if (scsi_bufflen(SCpnt) != len) { >> +WARN_ON(1); > > NAK. The call tr

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2007-09-12 Thread Russell King
On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote: > - if (SCpnt->request_bufflen != len) > + if (scsi_bufflen(SCpnt) != len) { > + WARN_ON(1); NAK. The call trace generally doesn't provide any additional information on the cause of the error

[PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2007-09-11 Thread Boaz Harrosh
- convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/arm/acornscsi.c | 14 +++--- drivers/scsi/arm/scsi.h | 34 +++--- 2 files changed, 18 insertions(+), 30 deletions(-) diff --git a/drivers/scs