Re: [PATCH 06/22] scsi: stop decoding if scsi_normalize_sense() fails

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:00 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:20PM +0200, Hannes Reinecke wrote: >> If scsi_normalize_sense() fails we couldn't decode the sense >> buffer, so we should not try to interpret the result. >> We should rather dump the sense buffer instead and stop dec

Re: [PATCH 06/22] scsi: stop decoding if scsi_normalize_sense() fails

2014-08-31 Thread Christoph Hellwig
On Thu, Aug 28, 2014 at 07:33:20PM +0200, Hannes Reinecke wrote: > If scsi_normalize_sense() fails we couldn't decode the sense > buffer, so we should not try to interpret the result. > We should rather dump the sense buffer instead and stop decoding. as far as I can tell the old code doesn't inte

[PATCH 06/22] scsi: stop decoding if scsi_normalize_sense() fails

2014-08-28 Thread Hannes Reinecke
If scsi_normalize_sense() fails we couldn't decode the sense buffer, so we should not try to interpret the result. We should rather dump the sense buffer instead and stop decoding. Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 37 +++-- 1 file chan