Re: [PATCH 04/17] scsi: avoid useless free_list lock roundtrips

2014-02-07 Thread Paolo Bonzini
Il 05/02/2014 13:39, Christoph Hellwig ha scritto: Avoid hitting the host-wide free_list lock unless we need to put a command back onto the freelist. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/dri

Re: [PATCH 04/17] scsi: avoid useless free_list lock roundtrips

2014-02-06 Thread Christoph Hellwig
On Wed, Feb 05, 2014 at 03:44:04PM -0800, James Bottomley wrote: > Why do this? cmd is still likely to be not NULL, which helps the > compiler optimise. Because testing for non-NULL pointers gets that hint implicitly from gcc. -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH 04/17] scsi: avoid useless free_list lock roundtrips

2014-02-05 Thread James Bottomley
On Wed, 2014-02-05 at 04:39 -0800, Christoph Hellwig wrote: > Avoid hitting the host-wide free_list lock unless we need to put a command > back onto the freelist. This one looks like it can go independently on its own. > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/scsi.c | 13 ++

[PATCH 04/17] scsi: avoid useless free_list lock roundtrips

2014-02-05 Thread Christoph Hellwig
Avoid hitting the host-wide free_list lock unless we need to put a command back onto the freelist. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index ebcea6c.