Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

2017-01-11 Thread Madhani, Himanshu
On 1/11/17, 12:47 PM, "Bart Van Assche" wrote: >On Fri, 2016-12-23 at 20:23 -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> This patch does not change any functionality. > >Please also mention in the patch description what the purpose of cmd_flags >is. If I remember correctly the only

Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

2017-01-11 Thread Bart Van Assche
On Fri, 2016-12-23 at 20:23 -0800, Himanshu Madhani wrote: > From: Quinn Tran > > This patch does not change any functionality. Please also mention in the patch description what the purpose of cmd_flags is. If I remember correctly the only purpose of most flags is to make analyzing crash dumps e

Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

2017-01-09 Thread Madhani, Himanshu
On 1/9/17, 5:11 AM, "Christoph Hellwig" wrote: >On Fri, Dec 23, 2016 at 08:23:31PM -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> This patch does not change any functionality. > >... >> +++ b/drivers/scsi/qla2xxx/qla_target.c >> @@ -3294,7 +3294,6 @@ int qlt_abort_cmd(struct qla_tgt

Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

2017-01-09 Thread Christoph Hellwig
On Fri, Dec 23, 2016 at 08:23:31PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > This patch does not change any functionality. ... > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -3294,7 +3294,6 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd) > return EIO; > } > cm

[PATCH 03/11] qla2xxx: Make trace flags more readable.

2016-12-23 Thread Himanshu Madhani
From: Quinn Tran This patch does not change any functionality. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 27 +-- drivers/scsi/qla2xxx/qla_target.h | 54 +- drivers/scsi/qla2xxx/tcm_ql