Re: [PATCH 02/41] scsi: NCR5380: Mark expected switch fall-through

2018-11-28 Thread Gustavo A. R. Silva
Hi Michael, On 11/28/18 2:22 AM, Michael Schmitz wrote: I believe the 'if we get something weird' comment block relates to the default branch of the switch, _not_ the fall through from the case above (extended message received that we end up rejecting). Ordering the comments like you did just f

Re: [PATCH 02/41] scsi: NCR5380: Mark expected switch fall-through

2018-11-28 Thread Michael Schmitz
Gustavo, Am 28.11.18 um 17:24 schrieb Gustavo A. R. Silva: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced "Fall through to reject > message" > with a "fall through" annotation at

[PATCH 02/41] scsi: NCR5380: Mark expected switch fall-through

2018-11-27 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I replaced "Fall through to reject message" with a "fall through" annotation at the bottom of the case, which is what GCC is expecting to find. Signed-