Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
On Wed, Apr 08, 2015 at 04:32:57PM +0300, Sergei Shtylyov wrote: > Hello. > > On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: > > >now that we are monitoring the return value from attach, make the > >So you've first changed the method prototype and follow up with > the changes to the actual impl

Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sergei Shtylyov
Hello. On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the So you've first changed the method prototype and follow up with the changes to the actual implementations? That's backward. I'm afraid such changes can't be done piecemeal

[PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- sound/drivers/portman2x4.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/sound/drivers/por