Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-05 Thread Jens Axboe
On Tue, Dec 04 2007, Kiyoshi Ueda wrote: > Hi Boaz and Jens, > > On Tue, 04 Dec 2007 15:56:32 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > > +/** > > > + * blk_end_request - Helper function for drivers to complete the request. > > > + * @rq: the request being processed > > > + * @uptod

Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-04 Thread Kiyoshi Ueda
Hi Boaz and Jens, On Tue, 04 Dec 2007 15:56:32 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > +/** > > + * blk_end_request - Helper function for drivers to complete the request. > > + * @rq: the request being processed > > + * @uptodate: 1 for success, 0 for I/O error, < 0 for specific e

Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-04 Thread Kiyoshi Ueda
Hi Boaz, On Tue, 04 Dec 2007 15:56:32 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > +int blk_end_request(struct request *rq, int uptodate, int nr_bytes) > > +{ > > + struct request_queue *q = rq->q; > > + unsigned long flags = 0UL; > > + > > + if (blk_fs_request(rq) || blk_pc_request(rq

Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-04 Thread Boaz Harrosh
On Sat, Dec 01 2007 at 1:24 +0200, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > This patch adds 2 new interfaces for request completion: > o blk_end_request() : called without queue lock > o __blk_end_request() : called with queue lock held > > Some device drivers call some generic functions be

[PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch adds 2 new interfaces for request completion: o blk_end_request() : called without queue lock o __blk_end_request() : called with queue lock held Some device drivers call some generic functions below between end_that_request_{first/chunk} and end_that_request_last(). o add_disk_