Re: [PATCH 00/17] SCSI data path micro-optimizations

2014-02-06 Thread Christoph Hellwig
On Wed, Feb 05, 2014 at 03:41:04PM -0800, James Bottomley wrote: > I will say that you do make the series hard to review by including > things that do code churn for no gain: like making all the error > handling goto based instead of the current in-place if () clause > based ... this doesn't do any

Re: [PATCH 00/17] SCSI data path micro-optimizations

2014-02-05 Thread James Bottomley
On Wed, 2014-02-05 at 04:39 -0800, Christoph Hellwig wrote: > This series contains various optimizations for the SCSI data I/O path. > They increase the number of IOPS seen with iSCSI or SRP between 2% > and 3.5% in workloads that previously hit the host_lock hard. While this > isn't a lot it now

[PATCH 00/17] SCSI data path micro-optimizations

2014-02-05 Thread Christoph Hellwig
This series contains various optimizations for the SCSI data I/O path. They increase the number of IOPS seen with iSCSI or SRP between 2% and 3.5% in workloads that previously hit the host_lock hard. While this isn't a lot it now fully shifts the contention to the queue_lock, which will get out of