Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

2017-11-06 Thread Bart Van Assche
On Mon, 2017-11-06 at 19:58 +, Madhani, Himanshu wrote: > On Nov 5, 2017, at 4:18 PM, Bart Van Assche wrote: > > The qla2xxx driver does not crash if apply these four patches on kernel > > v4.14-rc8 and load the qla2xxx driver on my test setup. Point-to-point > > mode seems broken again but I

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

2017-11-06 Thread Madhani, Himanshu
Hi Bart, > On Nov 5, 2017, at 4:18 PM, Bart Van Assche wrote: > > On Wed, 2017-11-01 at 19:18 +, Madhani, Himanshu wrote: >> Hi Kees, >> >>> On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: >>> >>> On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: This breaks out the logical steps t

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

2017-11-05 Thread Bart Van Assche
On Wed, 2017-11-01 at 19:18 +, Madhani, Himanshu wrote: > Hi Kees, > > > On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: > > > > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: > > > This breaks out the logical steps to convert the qla2xxx timers: > > > > > > 1) init_timer() -> setup_tim

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

2017-11-01 Thread Madhani, Himanshu
Hi Kees, > On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: > > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: >> This breaks out the logical steps to convert the qla2xxx timers: >> >> 1) init_timer() -> setup_timer() >> 2) refactor qla2x00_start_timer() to not pass callback as argument >> 3

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

2017-11-01 Thread Kees Cook
On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: > This breaks out the logical steps to convert the qla2xxx timers: > > 1) init_timer() -> setup_timer() > 2) refactor qla2x00_start_timer() to not pass callback as argument > 3) qla2x00_timer() to use timer_setup() > 4) qla2x00_sp_timeout() to use

[PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
This breaks out the logical steps to convert the qla2xxx timers: 1) init_timer() -> setup_timer() 2) refactor qla2x00_start_timer() to not pass callback as argument 3) qla2x00_timer() to use timer_setup() 4) qla2x00_sp_timeout() to use timer_setup() The resulting diff is identical to the patch th