Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread Joe Lawrence
On 04/13/2015 10:38 AM, James Bottomley wrote: > On Mon, 2015-04-13 at 10:06 -0400, Joe Lawrence wrote: >> On 04/12/2015 08:54 PM, James Bottomley wrote: >>> On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: On 12/30/2014 09:07 AM, Joe Lawrence wrote: > A colleague noticed that the mp

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread James Bottomley
On Mon, 2015-04-13 at 10:06 -0400, Joe Lawrence wrote: > On 04/12/2015 08:54 PM, James Bottomley wrote: > > On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: > >> On 12/30/2014 09:07 AM, Joe Lawrence wrote: > >>> A colleague noticed that the mpt2 and mpt3sas drivers do not correctly > >>> chec

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread Joe Lawrence
On 04/12/2015 08:54 PM, James Bottomley wrote: > On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: >> On 12/30/2014 09:07 AM, Joe Lawrence wrote: >>> A colleague noticed that the mpt2 and mpt3sas drivers do not correctly >>> check the PCI master abort pattern in _base_wait_for_doorbell_ack. T

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-12 Thread James Bottomley
On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: > On 12/30/2014 09:07 AM, Joe Lawrence wrote: > > A colleague noticed that the mpt2 and mpt3sas drivers do not correctly > > check the PCI master abort pattern in _base_wait_for_doorbell_ack. This > > pattern should be checked *prior* to any v

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-12 Thread Joe Lawrence
On 12/30/2014 09:07 AM, Joe Lawrence wrote: > A colleague noticed that the mpt2 and mpt3sas drivers do not correctly > check the PCI master abort pattern in _base_wait_for_doorbell_ack. This > pattern should be checked *prior* to any valid bit patterns, which would > always return true since a PCI

[PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2014-12-30 Thread Joe Lawrence
A colleague noticed that the mpt2 and mpt3sas drivers do not correctly check the PCI master abort pattern in _base_wait_for_doorbell_ack. This pattern should be checked *prior* to any valid bit patterns, which would always return true since a PCI read on master abort sets all bits high. The secon