Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-29 Thread Boaz Harrosh
On 01/29/2015 04:41 PM, James Bottomley wrote: > On Thu, 2015-01-29 at 15:00 +0200, Boaz Harrosh wrote: >> On 01/23/2015 03:12 PM, Christoph Hellwig wrote: >>> On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: There is some confusion in the SCSI core and in SCSI LLDs around the

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-29 Thread Boaz Harrosh
On 01/29/2015 03:20 PM, Bart Van Assche wrote: > On 01/29/15 14:07, Boaz Harrosh wrote: >> On 01/26/2015 11:58 AM, Bart Van Assche wrote: >> >>> Hello Christoph, >>> >>> This makes sense to me. I will rework this patch series as you proposed. >> >> Do you have a bidi setup to test against? >> >> Se

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-29 Thread James Bottomley
On Thu, 2015-01-29 at 15:00 +0200, Boaz Harrosh wrote: > On 01/23/2015 03:12 PM, Christoph Hellwig wrote: > > On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: > >> There is some confusion in the SCSI core and in SCSI LLDs around the > >> meaning of sc_data_direction and whether or n

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-29 Thread Bart Van Assche
On 01/29/15 14:07, Boaz Harrosh wrote: > On 01/26/2015 11:58 AM, Bart Van Assche wrote: > >> Hello Christoph, >> >> This makes sense to me. I will rework this patch series as you proposed. > > Do you have a bidi setup to test against? > > Sending xor command to scsi_dbg is only half the test for

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-29 Thread Boaz Harrosh
On 01/26/2015 11:58 AM, Bart Van Assche wrote: > Hello Christoph, > > This makes sense to me. I will rework this patch series as you proposed. > Do you have a bidi setup to test against? Sending xor command to scsi_dbg is only half the test for me because, yes there are two buffers, but they a

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-29 Thread Boaz Harrosh
On 01/23/2015 03:12 PM, Christoph Hellwig wrote: > On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: >> There is some confusion in the SCSI core and in SCSI LLDs around the >> meaning of sc_data_direction and whether or not this member can have the >> value DMA_BIDIRECTIONAL. Clear u

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-26 Thread Bart Van Assche
On 01/23/15 14:12, Christoph Hellwig wrote: > On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: >> There is some confusion in the SCSI core and in SCSI LLDs around the >> meaning of sc_data_direction and whether or not this member can have the >> value DMA_BIDIRECTIONAL. Clear up thi

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-23 Thread Christoph Hellwig
On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: > There is some confusion in the SCSI core and in SCSI LLDs around the > meaning of sc_data_direction and whether or not this member can have the > value DMA_BIDIRECTIONAL. Clear up this confusion. The patches in this > series are: I

[PATCH 0/17] Clear up bidi command confusion

2015-01-23 Thread Bart Van Assche
There is some confusion in the SCSI core and in SCSI LLDs around the meaning of sc_data_direction and whether or not this member can have the value DMA_BIDIRECTIONAL. Clear up this confusion. The patches in this series are: 0001-Clear-up-sc_data_direction-documentation.patch 0002-Clean-up-scsi_ioc