Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-11-16 Thread Xose Vazquez Perez
Bart Van Assche wrote: > [PATCH] qla2xxx: Fix rwlock recursion > > Fixes: 8dfa4b5a9b44 ("qla2xxx: Fix sparse annotation") > Signed-off-by: Bart Van Assche > Reported-by: Himanshu Madhani > Cc: Giridhar Malavali > --- > drivers/scsi/qla2xxx/qla_nx.c | 3 ++- > 1 file changed, 2 insertions(+)

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-10-26 Thread Himanshu Madhani
Hi Bart, On 10/14/15, 4:07 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Himanshu Madhani" wrote: >Hi Bart, > >> On Oct 14, 2015, at 10:33 AM, Bart Van Assche >> wrote: >> >> On 10/14/2015 08:57 AM, Himanshu Madhani wrote: >>> This patch fixes rwlock recursion introduced for ISP82XX by

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-10-15 Thread Hannes Reinecke
On 10/14/2015 05:57 PM, Himanshu Madhani wrote: > This patch fixes rwlock recursion introduced for ISP82XX by > commit 8dfa4b5a ("qla2xxx: Fix sparse annotations") > > Original patch fixes other sparse warnings which did not cause > any regression. So instead of reverting complete patch, this patc

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-10-14 Thread Himanshu Madhani
Hi Bart, > On Oct 14, 2015, at 10:33 AM, Bart Van Assche > wrote: > > On 10/14/2015 08:57 AM, Himanshu Madhani wrote: >> This patch fixes rwlock recursion introduced for ISP82XX by >> commit 8dfa4b5a ("qla2xxx: Fix sparse annotations") > > Hello Himanshu, > > Would it be possible to test whe

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-10-14 Thread Bart Van Assche
On 10/14/2015 08:57 AM, Himanshu Madhani wrote: This patch fixes rwlock recursion introduced for ISP82XX by commit 8dfa4b5a ("qla2xxx: Fix sparse annotations") Hello Himanshu, Would it be possible to test whether the (untested) patch below also fixes the observed rwlock recursion ? Thanks,

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-10-14 Thread Bart Van Assche
On 10/14/2015 08:57 AM, Himanshu Madhani wrote: -qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong off_in, -void __iomem **off_out) +qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong *off) { Hello Himanshu, Do you think it would be possible to ke

[PATCH 2/2] qla2xxx: fix rwlock recursion

2015-10-14 Thread Himanshu Madhani
This patch fixes rwlock recursion introduced for ISP82XX by commit 8dfa4b5a ("qla2xxx: Fix sparse annotations") Original patch fixes other sparse warnings which did not cause any regression. So instead of reverting complete patch, this patch will revert only part which caused recursion. stack tra