Re: [PATCH] ufs: adjust queue settings to PRDT limitations

2013-09-23 Thread Akinobu Mita
> Ideally there should be comment here to explain the reason for this > limitation. I see comments in commit text but not here in code. > Its not general practice to browse through history to understand the reason > behind this limitations. so it always helps to add comments in code itself. OK,

Re: [PATCH] ufs: adjust queue settings to PRDT limitations

2013-09-23 Thread Subhash Jadavani
On 9/21/2013 12:06 PM, Akinobu Mita wrote: The data byte count field of PRDT indicates the length of data block which is a segment of data transfer for SCSI commands. The value of this field shall have Dword granularity and the the maximum of length is 256KB. This adjusts dma pad mask and max s

[PATCH] ufs: adjust queue settings to PRDT limitations

2013-09-20 Thread Akinobu Mita
The data byte count field of PRDT indicates the length of data block which is a segment of data transfer for SCSI commands. The value of this field shall have Dword granularity and the the maximum of length is 256KB. This adjusts dma pad mask and max segment size to the above-mentioned PRDT limit