Re: [PATCH] sg: fix integer overflow (fwd)

2014-01-24 Thread Mikulas Patocka
On Fri, 24 Jan 2014, Mikulas Patocka wrote: > > > On Fri, 24 Jan 2014, James Bottomley wrote: > > > On Fri, 2014-01-24 at 11:34 -0500, Mikulas Patocka wrote: > > > On alpha, USER_HZ may be higher than HZ. This results in integer overflow > > > in MULDIV. > > > > > > Signed-off-by: Mikulas Pa

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread Mikulas Patocka
> zero, which will cause the queue default timeout to be applied instead. > > > > I'd fix it in the macro rather than having code peppered with #ifs > > You can't easily fix it in the macro: "MULDIV (INT_MAX, USER_HZ, HZ)" is > undefined value if USER_HZ >

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread Mikulas Patocka
On Fri, 24 Jan 2014, James Bottomley wrote: > On Fri, 2014-01-24 at 11:34 -0500, Mikulas Patocka wrote: > > On alpha, USER_HZ may be higher than HZ. This results in integer overflow > > in MULDIV. > > > > Signed-off-by: Mikulas Patocka > > Cc: sta...@vger.kernel.org > > > > --- > > drivers/s

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread James Bottomley
On Fri, 2014-01-24 at 11:34 -0500, Mikulas Patocka wrote: > On alpha, USER_HZ may be higher than HZ. This results in integer overflow > in MULDIV. > > Signed-off-by: Mikulas Patocka > Cc: sta...@vger.kernel.org > > --- > drivers/scsi/sg.c |2 ++ > 1 file changed, 2 insertions(+) > > Index:

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread Douglas Gilbert
On 14-01-24 11:34 AM, Mikulas Patocka wrote: On alpha, USER_HZ may be higher than HZ. This results in integer overflow in MULDIV. Signed-off-by: Mikulas Patocka Acked-by: Douglas Gilbert Cc: sta...@vger.kernel.org --- drivers/scsi/sg.c |2 ++ 1 file changed, 2 insertions(+) Index:

[PATCH] sg: fix integer overflow

2014-01-24 Thread Mikulas Patocka
On alpha, USER_HZ may be higher than HZ. This results in integer overflow in MULDIV. Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org --- drivers/scsi/sg.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-3.13/drivers/scsi/sg.c ==