Re: [PATCH] sd: read unmap block limits even if lbpme=0

2017-08-17 Thread Tom Yan
On 17 August 2017 at 10:11, Martin K. Petersen wrote: > > Tom, > > I have to confess I'm wary of interpreting values reported by a device > that messes up setting the single bit flag that enables the feature. > FWIW, this implementation in particular works pretty well as far as I can tell. The va

Re: [PATCH] sd: read unmap block limits even if lbpme=0

2017-08-16 Thread Martin K. Petersen
Tom, > Some devices may not be decent enough to report lbpme bit properly > even when they do support unmap and report relevant information in the > block limits and logical block provisioning VPDs properly (Namely, > ASMedia ASM1351, a UAS-SATA bridge). One of the reasons is, lbpme=1 is > not a

[PATCH] sd: read unmap block limits even if lbpme=0

2017-08-14 Thread tom . ty89
From: Tom Yan Some devices may not be decent enough to report lbpme bit properly even when they do support unmap and report relevant information in the block limits and logical block provisioning VPDs properly (Namely, ASMedia ASM1351, a UAS-SATA bridge). One of the reasons is, lbpme=1 is not a r