Re: [PATCH] sd: implement stop_on_shutdown

2007-02-05 Thread James Bottomley
On Mon, 2007-02-05 at 18:43 +0900, Tejun Heo wrote: > James, do you think such change to sd is acceptable? As the original > patch, the default behavior won't be changed, so unless specifically > configured (probably during boot by dist) there won't be any behavior > change. Yes, as long as the d

Re: [PATCH] sd: implement stop_on_shutdown

2007-02-05 Thread Tejun Heo
James Bottomley wrote: > There are practical problems to handling this in sd, namely that the > power handling commands and state model are part of the ATA command set, > not part of the SCSI command set. SAT really only covers the basics of > mapping the different power management models. I see.

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-21 Thread Stefan Richter
Tejun Heo wrote: > This is just > for small little machines running SATA and possibly USB disks (dunno > their SAT implement START_STOP tho) which are currently having problems > shutting down its disks on sleep to disk and sometimes poweroff. It's also useful for FireWire HDDs. Those are basicall

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread James Bottomley
On Sat, 2007-01-20 at 04:50 -0500, Jeff Garzik wrote: > Tejun Heo wrote: > > Darrick J. Wong wrote: > >> Tejun Heo wrote: > >>> sd doesn't stop (unload head) on shutdown. This behavior is necessary > >>> for multi initiator cases. Unloading head by powering off stresses > >>> the drive and someti

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread James Bottomley
On Sat, 2007-01-20 at 12:22 +0900, Tejun Heo wrote: > Darrick J. Wong wrote: > > Tejun Heo wrote: > >> sd doesn't stop (unload head) on shutdown. This behavior is necessary > >> for multi initiator cases. Unloading head by powering off stresses > >> the drive and sometimes produces distinct clunk

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> For ATA, it's currently being done inside libata proper (a bit ugly). >> It would be nice to have those implemented at sd layer but I wonder how >> useful it's going to be for actual SCSI devices. Do people actually >> suspend using SCSI? If it's useful at

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread Jeff Garzik
Tejun Heo wrote: Darrick J. Wong wrote: Tejun Heo wrote: sd doesn't stop (unload head) on shutdown. This behavior is necessary for multi initiator cases. Unloading head by powering off stresses the drive and sometimes produces distinct clunking noise which apparently disturbs users considerin

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-19 Thread Tejun Heo
Darrick J. Wong wrote: > Tejun Heo wrote: >> sd doesn't stop (unload head) on shutdown. This behavior is necessary >> for multi initiator cases. Unloading head by powering off stresses >> the drive and sometimes produces distinct clunking noise which >> apparently disturbs users considering multi

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-19 Thread Tejun Heo
Hello, Douglas. Douglas Gilbert wrote: >> This patch implements sd attribute stop_on_shutdown. If set to 1, sd >> stops the drive on non-restarting shutdown. stop_on_shutdown is >> initialized from sd parameter stop_on_shutdown_default which defaults >> to 0. So, this patch does not change the

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-19 Thread Darrick J. Wong
Tejun Heo wrote: > sd doesn't stop (unload head) on shutdown. This behavior is necessary > for multi initiator cases. Unloading head by powering off stresses > the drive and sometimes produces distinct clunking noise which > apparently disturbs users considering multiple reports on different > di

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-19 Thread Douglas Gilbert
Tejun Heo wrote: > sd doesn't stop (unload head) on shutdown. This behavior is necessary > for multi initiator cases. Unloading head by powering off stresses > the drive and sometimes produces distinct clunking noise which > apparently disturbs users considering multiple reports on different > di

[PATCH] sd: implement stop_on_shutdown

2007-01-19 Thread Tejun Heo
sd doesn't stop (unload head) on shutdown. This behavior is necessary for multi initiator cases. Unloading head by powering off stresses the drive and sometimes produces distinct clunking noise which apparently disturbs users considering multiple reports on different distributions. halt(8) usual