Re: [PATCH] scsi_lib: add NULL check to scsi_setup_blk_pc_cmnd

2012-07-25 Thread Jörn Engel
On Tue, 24 July 2012 09:01:41 +0400, James Bottomley wrote: > On Mon, 2012-07-23 at 15:24 -0400, Jörn Engel wrote: > > On Mon, 23 July 2012 23:45:55 +0400, James Bottomley wrote: > > > > > > Have you checked this with the patches in scsi-misc? There's a series > > > of patches in there that alter

Re: [PATCH] scsi_lib: add NULL check to scsi_setup_blk_pc_cmnd

2012-07-23 Thread James Bottomley
On Mon, 2012-07-23 at 15:24 -0400, Jörn Engel wrote: > On Mon, 23 July 2012 23:45:55 +0400, James Bottomley wrote: > > On Mon, 2012-07-23 at 13:32 -0400, Jörn Engel wrote: > > > At least two slightly different paths can lead to a NULL pointer > > > dereference in scsi_prep_state_check and have been

Re: [PATCH] scsi_lib: add NULL check to scsi_setup_blk_pc_cmnd

2012-07-23 Thread Jörn Engel
On Mon, 23 July 2012 23:45:55 +0400, James Bottomley wrote: > On Mon, 2012-07-23 at 13:32 -0400, Jörn Engel wrote: > > At least two slightly different paths can lead to a NULL pointer > > dereference in scsi_prep_state_check and have been hit in practice. > > Have you checked this with the patches

Re: [PATCH] scsi_lib: add NULL check to scsi_setup_blk_pc_cmnd

2012-07-23 Thread James Bottomley
On Mon, 2012-07-23 at 13:32 -0400, Jörn Engel wrote: > At least two slightly different paths can lead to a NULL pointer > dereference in scsi_prep_state_check and have been hit in practice. Have you checked this with the patches in scsi-misc? There's a series of patches in there that alters the w

[PATCH] scsi_lib: add NULL check to scsi_setup_blk_pc_cmnd

2012-07-23 Thread Jörn Engel
At least two slightly different paths can lead to a NULL pointer dereference in scsi_prep_state_check and have been hit in practice. 1. Call Trace: [] scsi_setup_blk_pc_cmnd+0x2b/0x170 [] sd_prep_fn+0x568/0xdd0 [] blk_peek_request+0xb4/0x240 [] scsi_request_fn+0x43e/0x4a0 [] __blk_run_queue+0x