Re: [PATCH] scsi_dh_alua: Do not run STPG for implicit ALUA

2019-10-19 Thread Hannes Reinecke
On 10/18/19 11:44 PM, Martin K. Petersen wrote: Hannes, If a target only supports implicit ALUA sending a SET TARGET PORT GROUPS command is not only pointless, but might actually cause issues. We already have a conditional in alua_stpg(): if (!(pg->tpgs & TPGS_MODE_EXPLICIT)) {

Re: [PATCH] scsi_dh_alua: Do not run STPG for implicit ALUA

2019-10-18 Thread Martin K. Petersen
Hannes, > If a target only supports implicit ALUA sending a SET TARGET PORT > GROUPS command is not only pointless, but might actually cause issues. We already have a conditional in alua_stpg(): if (!(pg->tpgs & TPGS_MODE_EXPLICIT)) { /* Only implicit ALUA supported, re

[PATCH] scsi_dh_alua: Do not run STPG for implicit ALUA

2019-10-18 Thread Hannes Reinecke
If a target only supports implicit ALUA sending a SET TARGET PORT GROUPS command is not only pointless, but might actually cause issues. So don't. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/de