Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread James Bottomley
On Mon, 2008-02-18 at 00:11 +0900, FUJITA Tomonori wrote: > On Sun, 17 Feb 2008 09:02:14 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > On Sun, 2008-02-17 at 23:52 +0900, FUJITA Tomonori wrote: > > > On Sun, 17 Feb 2008 07:28:48 -0700 > > > Matthew Wilcox <[EMAIL PROTECTED]> wrote:

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 09:02:14 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sun, 2008-02-17 at 23:52 +0900, FUJITA Tomonori wrote: > > On Sun, 17 Feb 2008 07:28:48 -0700 > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > > > On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wro

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 23:52 +0900, FUJITA Tomonori wrote: > On Sun, 17 Feb 2008 07:28:48 -0700 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote: > > > No, he means that kmap_atomic can only map a page of data. This makes > > > sing

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 07:28:48 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote: > > No, he means that kmap_atomic can only map a page of data. This makes > > single page only sg list entries and input assumption into this loop. > > w

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread Matthew Wilcox
On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote: > No, he means that kmap_atomic can only map a page of data. This makes > single page only sg list entries and input assumption into this loop. > with ENABLE_CLUSTERING, that's potentially not true. Of course, this > accidentally w

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 07:10 -0700, Matthew Wilcox wrote: > On Sat, Feb 16, 2008 at 11:57:15PM +0900, FUJITA Tomonori wrote: > > scsi_debug does at several places: > > > > for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) { > > kaddr = (unsigned char *) > > kmap_atomic(sg_page(s

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread Matthew Wilcox
On Sat, Feb 16, 2008 at 11:57:15PM +0900, FUJITA Tomonori wrote: > scsi_debug does at several places: > > for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) { > kaddr = (unsigned char *) > kmap_atomic(sg_page(sg), KM_USER0); > > > We cannot do something like that with the c

Re: [PATCH] scsi_debug: disable clustering

2008-02-16 Thread Douglas Gilbert
FUJITA Tomonori wrote: From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] scsi_debug: disable clustering scsi_debug does at several places: for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) { kaddr = (unsigned char *) kmap_atomic(sg_page(sg), KM_

[PATCH] scsi_debug: disable clustering

2008-02-16 Thread FUJITA Tomonori
From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] scsi_debug: disable clustering scsi_debug does at several places: for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) { kaddr = (unsigned char *) kmap_atomic(sg_page(sg), KM_USER0); We cannot do so