Re: [PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

2016-11-15 Thread Zang Leigang
Ok, got it. I will resend a new patch. On Tue, Nov 15, 2016 at 11:00:12AM -0800, Subhash Jadavani wrote: > On 2016-11-15 04:25, Zang Leigang wrote: > >We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler > >fails. So I think UFSHCD_STATE_ERROR means host not works any more. > >Set it befo

Re: [PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

2016-11-15 Thread Subhash Jadavani
On 2016-11-15 04:25, Zang Leigang wrote: We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler fails. So I think UFSHCD_STATE_ERROR means host not works any more. Set it before schedule eh_work is not correct. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers

[PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

2016-11-15 Thread Zang Leigang
We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler fails. So I think UFSHCD_STATE_ERROR means host not works any more. Set it before schedule eh_work is not correct. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 05c7456..a7724ad 1