Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 11:36 AM, Madhani, Himanshu wrote: > Hi Kees, > >> On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: >> >> How very strange. I don't see any code change with this patch. Even >> the passed arguments are the same; it's only enforcing the types now. >> And the system is fine wi

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Madhani, Himanshu
Hi Kees, > On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: > > How very strange. I don't see any code change with this patch. Even > the passed arguments are the same; it's only enforcing the types now. > And the system is fine with only this patch reverted? Yes. Agree patch looks okay, but wit

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 11:16 AM, Madhani, Himanshu wrote: > Hi Bart, > >> On Oct 31, 2017, at 11:12 AM, Bart Van Assche wrote: >> >> On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: >>> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen >>> wrote: > In preparation for unconditional

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Madhani, Himanshu
Hi Bart, > On Oct 31, 2017, at 11:12 AM, Bart Van Assche wrote: > > On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: >> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen >> wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callback

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Bart Van Assche
On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: > On Oct 31, 2017, at 8:49 AM, Martin K. Petersen > wrote: > > > In preparation for unconditionally passing the struct timer_list > > > pointer to all timer callbacks, switch to using the new timer_setup() > > > and from_timer() to pass

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Madhani, Himanshu
Hi Martin/Kees, > On Oct 31, 2017, at 8:49 AM, Martin K. Petersen > wrote: > > > Kees, > >> In preparation for unconditionally passing the struct timer_list >> pointer to all timer callbacks, switch to using the new timer_setup() >> and from_timer() to pass the timer pointer explicitly. > >

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Cavium folks: Please verify! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Or

[PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: qla2xxx-upstr...@qlogic.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.ke

[PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: qla2xxx-upstr...@qlogic.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.ke