Re: [PATCH] scsi: myrs: avoid stack overflow warning

2018-11-05 Thread Martin K. Petersen
Arnd, > Putting a 1024 byte data structure on the stack is generally a bad idea. > On 32-bit systems, it also triggers a compile-time warning when building > with -Og: Applied to 4.20/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: myrs: avoid stack overflow warning

2018-11-03 Thread Hannes Reinecke
On 11/2/18 4:44 PM, Arnd Bergmann wrote: Putting a 1024 byte data structure on the stack is generally a bad idea. On 32-bit systems, it also triggers a compile-time warning when building with -Og: drivers/scsi/myrs.c: In function 'myrs_get_ctlr_info': drivers/scsi/myrs.c:212:1: error: the frame

[PATCH] scsi: myrs: avoid stack overflow warning

2018-11-02 Thread Arnd Bergmann
Putting a 1024 byte data structure on the stack is generally a bad idea. On 32-bit systems, it also triggers a compile-time warning when building with -Og: drivers/scsi/myrs.c: In function 'myrs_get_ctlr_info': drivers/scsi/myrs.c:212:1: error: the frame size of 1028 bytes is larger than 1024 byt