Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-10-10 Thread Martin K. Petersen
Nathan, >> The exact same code also exists in drivers/scsi/mpt3sas/. I had a similar >> patch for both drivers, but saw that yours now got merged for fusion. >> >> If you don't mind, could you fix mpt3sas_base.c the same way? >> >> Arnd > > Hi Arnd, > > I did sent a patch for this a littl

Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-10-02 Thread Nathan Chancellor
On Tue, Oct 02, 2018 at 02:58:21PM +0200, Arnd Bergmann wrote: > On Sat, Sep 15, 2018 at 8:38 AM Nathan Chancellor > wrote: > > > Reported-by: Nick Desaulniers > > Signed-off-by: Nathan Chancellor > > --- > > drivers/message/fusion/mptbase.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 del

Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-10-02 Thread Arnd Bergmann
On Sat, Sep 15, 2018 at 8:38 AM Nathan Chancellor wrote: > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor > --- > drivers/message/fusion/mptbase.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/message/fusion/mptbase.c > b/drivers/messag

Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-09-27 Thread Martin K. Petersen
Nathan, > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. Applied to 4.20/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-09-17 Thread Nick Desaulniers
On Fri, Sep 14, 2018 at 11:36 PM Nathan Chancellor wrote: > > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. > > drivers/message/fusion/mptbase.c:338:11: warning: equality comparison > with extraneous parentheses [-Wparentheses-equality] > if

[PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-09-14 Thread Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single conditional statement. drivers/message/fusion/mptbase.c:338:11: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((ioc == NULL)) ^~~ drivers/message/fusion/mptbase.