On Sun, Feb 25, 2018 at 11:02 AM, Johannes Thumshirn wrote:
> Arnd Bergmann writes:
>> 32-bit architectures generally cannot use writeq(), so we now get a build
>> failure for the lpfc driver:
>>
>> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put':
>> drivers/scsi/lpfc/lpfc_sli.c:145:
Arnd Bergmann writes:
> 32-bit architectures generally cannot use writeq(), so we now get a build
> failure for the lpfc driver:
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put':
> drivers/scsi/lpfc/lpfc_sli.c:145:4: error: implicit declaration of function
> 'writeq'; did you mean
About to post a patch to fix. Rather than fidgeting with the copy
routine, I want to go back to what we originally proposed - writeq() on
64bit, writel() on 32-bit.
-- james
On 2/23/2018 1:02 PM, Arnd Bergmann wrote:
On Fri, Feb 23, 2018 at 4:36 PM, Arnd Bergmann wrote:
@@ -138,12 +137,10
On Fri, Feb 23, 2018 at 4:36 PM, Arnd Bergmann wrote:
> @@ -138,12 +137,10 @@ lpfc_sli4_wq_put(struct lpfc_queue *q, union lpfc_wqe
> *wqe)
> if (q->phba->sli3_options & LPFC_SLI4_PHWQ_ENABLED)
> bf_set(wqe_wqid, &wqe->generic.wqe_com, q->queue_id);
> lpfc_sli_pcim
e: [PATCH] scsi: lpfc: use memcpy_toio instead of writeq
>
> On Fri, Feb 23, 2018 at 7:09 PM, David Laight wrote:
> > From: Andy Shevchenko
> >> Sent: 23 February 2018 16:51
> >> On Fri, Feb 23, 2018 at 6:41 PM, David Laight
> >> wrote:
>
>
> &g
From: Andy Shevchenko
> Sent: 23 February 2018 16:51
> On Fri, Feb 23, 2018 at 6:41 PM, David Laight wrote:
> > From: Arnd Bergmann
> >> Sent: 23 February 2018 15:37
> >>
> >> 32-bit architectures generally cannot use writeq(), so we now get a build
> >> failure for the lpfc driver:
> >>
> >> driv
On Fri, Feb 23, 2018 at 7:09 PM, David Laight wrote:
> From: Andy Shevchenko
>> Sent: 23 February 2018 16:51
>> On Fri, Feb 23, 2018 at 6:41 PM, David Laight
>> wrote:
>> The side-effect I referred previously is about tails, i.e. unaligned
>> bytes are transferred in portions
>> like
>> 7 on
From: Arnd Bergmann
> Sent: 23 February 2018 15:37
>
> 32-bit architectures generally cannot use writeq(), so we now get a build
> failure for the lpfc driver:
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put':
> drivers/scsi/lpfc/lpfc_sli.c:145:4: error: implicit declaration of fu
On Fri, Feb 23, 2018 at 6:51 PM, Andy Shevchenko
wrote:
> On Fri, Feb 23, 2018 at 6:41 PM, David Laight wrote:
>> From: Arnd Bergmann
>>> Sent: 23 February 2018 15:37
>>>
>>> 32-bit architectures generally cannot use writeq(), so we now get a build
>>> failure for the lpfc driver:
>>>
>>> drivers
On Fri, Feb 23, 2018 at 6:41 PM, David Laight wrote:
> From: Arnd Bergmann
>> Sent: 23 February 2018 15:37
>>
>> 32-bit architectures generally cannot use writeq(), so we now get a build
>> failure for the lpfc driver:
>>
>> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put':
>> drivers/
On Fri, Feb 23, 2018 at 5:41 PM, David Laight wrote:
> From: Arnd Bergmann
>> Sent: 23 February 2018 15:37
>>
>> 32-bit architectures generally cannot use writeq(), so we now get a build
>> failure for the lpfc driver:
>>
>> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put':
>> drivers/
On Fri, Feb 23, 2018 at 5:59 PM, Andy Shevchenko
wrote:
> On Fri, Feb 23, 2018 at 5:36 PM, Arnd Bergmann wrote:
> IIRC memcpy_toio() doesn't increment the destination address.
>
> lo_hi or hi_lo helpers sound better.
Ah, sorry, I messed up with writesl() / etc.
memcpy_toio() has another side-e
On Fri, Feb 23, 2018 at 5:36 PM, Arnd Bergmann wrote:
> 32-bit architectures generally cannot use writeq(), so we now get a build
> failure for the lpfc driver:
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put':
> drivers/scsi/lpfc/lpfc_sli.c:145:4: error: implicit declaration of fu
32-bit architectures generally cannot use writeq(), so we now get a build
failure for the lpfc driver:
drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put':
drivers/scsi/lpfc/lpfc_sli.c:145:4: error: implicit declaration of function
'writeq'; did you mean 'writeb'? [-Werror=implicit-funct
14 matches
Mail list logo
