Re: [PATCH] scsi: libcxgbi: fix skb use after free

2017-05-23 Thread Martin K. Petersen
Varun, > skb->data is assigned to task->hdr in cxgbi_conn_alloc_pdu(), > skb gets freed after tx but task->hdr is still dereferenced in > iscsi_tcp_task_xmit() to avoid this call skb_get() after allocating > skb and free the skb in cxgbi_cleanup_task() or before allocating new > skb in cxgbi_conn

Re: [PATCH] scsi: libcxgbi: fix skb use after free

2017-05-18 Thread Martin K. Petersen
> skb->data is assigned to task->hdr in cxgbi_conn_alloc_pdu(), > skb gets freed after tx but task->hdr is still dereferenced in > iscsi_tcp_task_xmit() to avoid this call skb_get() after allocating > skb and free the skb in cxgbi_cleanup_task() or before allocating new > skb in cxgbi_conn_alloc_p

[PATCH] scsi: libcxgbi: fix skb use after free

2017-05-16 Thread Varun Prakash
skb->data is assigned to task->hdr in cxgbi_conn_alloc_pdu(), skb gets freed after tx but task->hdr is still dereferenced in iscsi_tcp_task_xmit() to avoid this call skb_get() after allocating skb and free the skb in cxgbi_cleanup_task() or before allocating new skb in cxgbi_conn_alloc_pdu(). Sign