Re: [PATCH] scsi: iterate over devices individually for /proc/scsi/scsi

2007-10-30 Thread Christoph Hellwig
This patch looks a lot better and is how seq_file should be used. I'm still not entirely happy about adding more features to this long-deprecated interface, but if others agree with this patch you'll get my ACK aswell. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH] scsi: iterate over devices individually for /proc/scsi/scsi

2007-10-29 Thread Jeff Mahoney
Christoph Hellwig wrote: > On Thu, Apr 12, 2007 at 03:34:32PM -0400, Jeff Mahoney wrote: >> On systems with very large numbers (> 1600 or so) of SCSI devices, >> cat /proc/scsi/scsi ends up failing with -ENOMEM. This is due to >> the show routine simply iterating over all of the devices with >>

Re: [PATCH] scsi: iterate over devices individually for /proc/scsi/scsi

2007-04-13 Thread Christoph Hellwig
On Thu, Apr 12, 2007 at 03:34:32PM -0400, Jeff Mahoney wrote: > On systems with very large numbers (> 1600 or so) of SCSI devices, > cat /proc/scsi/scsi ends up failing with -ENOMEM. This is due to > the show routine simply iterating over all of the devices with > bus_for_each_dev(), and trying

Re: [PATCH] scsi: iterate over devices individually for /proc/scsi/scsi

2007-04-12 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Mahoney wrote: > On systems with very large numbers (> 1600 or so) of SCSI devices, > cat /proc/scsi/scsi ends up failing with -ENOMEM. This is due to > the show routine simply iterating over all of the devices with > bus_for_each_dev(), and t

[PATCH] scsi: iterate over devices individually for /proc/scsi/scsi

2007-04-12 Thread Jeff Mahoney
On systems with very large numbers (> 1600 or so) of SCSI devices, cat /proc/scsi/scsi ends up failing with -ENOMEM. This is due to the show routine simply iterating over all of the devices with bus_for_each_dev(), and trying to dump all of them into the buffer at the same time. On my test sys