Re: [PATCH] scsi: hisi_sas: Fix NULL pointer dereference

2018-10-18 Thread Gustavo A. R. Silva
Hi, I just found another instance of this same issue at line 1053. Please, drop this patch and I'll send v2 addressing both instances, shortly. Thanks -- Gustavo On 10/18/18 6:41 PM, Gustavo A. R. Silva wrote: > There is a NULL pointer dereference in case *slot* happens to > be NULL at line 187

[PATCH] scsi: hisi_sas: Fix NULL pointer dereference

2018-10-18 Thread Gustavo A. R. Silva
There is a NULL pointer dereference in case *slot* happens to be NULL at line 1878: struct hisi_sas_cq *cq = &hisi_hba->cq[slot->dlvry_queue]; Notice that *slot* is being NULL checked at line 1881: if (slot), which implies it may be NULL. Fix this by placing the declaration and definitio